Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 #7933

Merged
merged 1 commit into from
Dec 4, 2020
Merged

V1 #7933

merged 1 commit into from
Dec 4, 2020

Conversation

modular-magician
Copy link
Collaborator

Add Notebooks Terraform module v1 support for Notebooks API
Notebooks API is GA since September 2020.
New features are developed in v1 only. Updating Terraform.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

notebooks: promoted `google_notebooks_instance` to GA
notebooks: promoted `google_notebooks_environment` to GA

Derived from GoogleCloudPlatform/magic-modules#4253

@modular-magician @ScottSuarez
V1 (hashicorp#4253)
e3a9a06 
* Update to v1 API

* Remove default option

* Restore v1beta1

* Update v1 order

* update iam tests to work correctly

* removed a < that corrupted compiliation

Co-authored-by: Scott Suarez <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xxl label Dec 4, 2020
@modular-magician modular-magician merged commit 3fd0300 into hashicorp:master Dec 4, 2020
@ghost
Copy link

ghost commented Jan 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
@modular-magician modular-magician deleted the downstream-pr-37816f6c72fe6db67fd94b753b2d8295685b72e7 branch November 17, 2024 00:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xxl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician